-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix phasar research tool to enable container build #664
base: vara-dev
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #664 +/- ##
============================================
- Coverage 68.20% 68.20% -0.01%
============================================
Files 333 333
Lines 25680 25682 +2
============================================
+ Hits 17516 17517 +1
- Misses 8164 8165 +1
☔ View full report in Codecov by Sentry. |
Should we merge this after the phasar changes were worked in? |
@fabianbs96 @boehmseb What's the current state of the phasar changes? Can we start to integrate this branch? |
The only remaining issue is to decide how to handle the llvm install. The options are:
|
If we can easily switch to 14 it's probably the simplest thing to do, especially as our LLVM state is also 14. |
We use llvm-14 in the container images anyway and for non-container builds the user should be responsible for supplying the correct llvm version.
@fabianbs96 @boehmseb What's the current state of this PR? We should resolve the llvm-14 issue to merge this one otherwise the branch will drift more and and more. |
This PR enables Phasar to be built in a container.
@MMory @pdschubert: There are two things that should be changed in phasar's
install-llvm.sh
script for this to work properly:sudo
for installation, this is not necessary when installing to a user-writeable directory (as we use here)